LGTM, love it!
https://codereview.chromium.org/240493007/diff/1/src/runtime.cc
File src/runtime.cc (left):
https://codereview.chromium.org/240493007/diff/1/src/runtime.cc#oldcode10933
src/runtime.cc:10933:
isolate->heap()->illegal_execution_state_string());
Turning this into a RUNTIME_ASSERT changes the error message being
thrown, but that should never be observable from user code, right?
https://codereview.chromium.org/240493007/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/240493007/diff/1/src/runtime.cc#newcode10915
src/runtime.cc:10915: static bool CheckExecutionState(Isolate* isolate,
int break_id) {
Yes! Enthusiastic +1!
https://codereview.chromium.org/240493007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
