Drive-by.

https://codereview.chromium.org/238803002/diff/20001/include/v8-debug.h
File include/v8-debug.h (left):

https://codereview.chromium.org/238803002/diff/20001/include/v8-debug.h#oldcode195
include/v8-debug.h:195: static void DebugBreak(Isolate* isolate = NULL);
Shouldn't these also go through V8_DEPRECATED before
backwards-incompatible removal of the default parameter?

https://codereview.chromium.org/238803002/diff/20001/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/238803002/diff/20001/include/v8.h#oldcode4851
include/v8.h:4851: static void TerminateExecution(Isolate* isolate =
NULL);
Shouldn't this go through V8_DEPRECATED first?

https://codereview.chromium.org/238803002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to