Revision: 20856
Author: [email protected]
Date: Thu Apr 17 14:58:03 2014 UTC
Log: Make Heap::AllocateRaw*String private.
[email protected]
Review URL: https://codereview.chromium.org/241023002
http://code.google.com/p/v8/source/detail?r=20856
Modified:
/branches/bleeding_edge/src/heap.cc
/branches/bleeding_edge/src/heap.h
/branches/bleeding_edge/test/cctest/test-alloc.cc
=======================================
--- /branches/bleeding_edge/src/heap.cc Thu Apr 17 13:27:02 2014 UTC
+++ /branches/bleeding_edge/src/heap.cc Thu Apr 17 14:58:03 2014 UTC
@@ -3390,7 +3390,7 @@
}
SeqTwoByteString* result;
- { MaybeObject* maybe_result = AllocateRawTwoByteString(1);
+ { MaybeObject* maybe_result = AllocateRawTwoByteString(1, NOT_TENURED);
if (!maybe_result->To<SeqTwoByteString>(&result)) return maybe_result;
}
result->SeqTwoByteStringSet(0, code);
=======================================
--- /branches/bleeding_edge/src/heap.h Thu Apr 17 13:53:06 2014 UTC
+++ /branches/bleeding_edge/src/heap.h Thu Apr 17 14:58:03 2014 UTC
@@ -826,20 +826,6 @@
MUST_USE_RESULT MaybeObject* AllocateInternalizedStringImpl(
T t, int chars, uint32_t hash_field);
- // Allocates and partially initializes a String. There are two String
- // encodings: ASCII and two byte. These functions allocate a string of
the
- // given length and set its map and length fields. The characters of the
- // string are uninitialized.
- // Returns Failure::RetryAfterGC(requested_bytes, space) if the
allocation
- // failed.
- // Please note this does not perform a garbage collection.
- MUST_USE_RESULT MaybeObject* AllocateRawOneByteString(
- int length,
- PretenureFlag pretenure = NOT_TENURED);
- MUST_USE_RESULT MaybeObject* AllocateRawTwoByteString(
- int length,
- PretenureFlag pretenure = NOT_TENURED);
-
// Computes a single character string where the character has code.
// A cache is used for ASCII codes.
// Returns Failure::RetryAfterGC(requested_bytes, space) if the
allocation
@@ -1989,7 +1975,7 @@
return (pretenure == TENURED) ? preferred_old_space : NEW_SPACE;
}
- // Allocates an uninitialized object. The memory is non-executable if
the
+ // Allocate an uninitialized object. The memory is non-executable if the
// hardware and OS allow. This is the single choke-point for allocations
// performed by the runtime and should not be bypassed (to extend this to
// inlined allocations, use the Heap::DisableInlineAllocation() support).
@@ -2009,6 +1995,15 @@
MUST_USE_RESULT MaybeObject* AllocateFixedArrayWithFiller(
int length, PretenureFlag pretenure, Object* filler);
+ // Allocate and partially initializes a String. There are two String
+ // encodings: ASCII and two byte. These functions allocate a string of
the
+ // given length and set its map and length fields. The characters of the
+ // string are uninitialized.
+ MUST_USE_RESULT MaybeObject* AllocateRawOneByteString(
+ int length, PretenureFlag pretenure);
+ MUST_USE_RESULT MaybeObject* AllocateRawTwoByteString(
+ int length, PretenureFlag pretenure);
+
// Initializes a JSObject based on its map.
void InitializeJSObjectFromMap(JSObject* obj,
FixedArray* properties,
=======================================
--- /branches/bleeding_edge/test/cctest/test-alloc.cc Thu Apr 17 13:27:02
2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-alloc.cc Thu Apr 17 14:58:03
2014 UTC
@@ -55,7 +55,7 @@
// Old data space.
SimulateFullSpace(heap->old_data_space());
- CHECK(!heap->AllocateRawOneByteString(100, TENURED)->IsFailure());
+ CHECK(!heap->AllocateByteArray(100, TENURED)->IsFailure());
// Old pointer space.
SimulateFullSpace(heap->old_pointer_space());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
