Reviewers: Yang,
Message:
Hi Yang, PTAL, thx!
--Michael
https://codereview.chromium.org/247013002/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/247013002/diff/40001/src/runtime.cc#newcode14852
src/runtime.cc:14852: initial_map = Map::AsElementsKind(initial_map,
to_kind);
There isn't a way for Map::AsElementsKind to return a null handle.
Description:
JSObject::DeepCopy and other functions returned an empty handle to
indicate an exception. All usages but one changed to return
MaybeHandles, and to use macros around the call.
The remaining work is in Compiler::GetUnoptimizedCode(), and when
that is turned into a MaybeHandle, then the macros dealing with
null handle returns can be eliminated.
Please review this at https://codereview.chromium.org/247013002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+99, -89 lines):
M src/api.cc
M src/isolate.h
M src/jsregexp.h
M src/jsregexp.cc
M src/objects.h
M src/objects.cc
M src/runtime.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
