LGTM.
https://codereview.chromium.org/240053010/diff/90001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/240053010/diff/90001/src/arm/code-stubs-arm.cc#newcode1506
src/arm/code-stubs-arm.cc:1506: // Called from JavaScript; parameters
are on stack as if calling JS function
nit: trailing full stop please
https://codereview.chromium.org/240053010/diff/90001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/240053010/diff/90001/src/ia32/code-stubs-ia32.cc#newcode2619
src/ia32/code-stubs-ia32.cc:2619:
Immediate(ExternalReference::isolate_address(masm->isolate())));
nit: s/masm->isolate()/isolate/ here...
https://codereview.chromium.org/240053010/diff/90001/src/ia32/code-stubs-ia32.cc#newcode2627
src/ia32/code-stubs-ia32.cc:2627: __ cmp(eax,
masm->isolate()->factory()->the_hole_value());
...and here...
https://codereview.chromium.org/240053010/diff/90001/src/ia32/code-stubs-ia32.cc#newcode2633
src/ia32/code-stubs-ia32.cc:2633: // Check for failure result.
nit: s/failure/exception/ to avoid confusion? (If you change it, rename
the "failure_returned" label too.)
https://codereview.chromium.org/240053010/diff/90001/src/ia32/code-stubs-ia32.cc#newcode2639
src/ia32/code-stubs-ia32.cc:2639: Isolate::kPendingExceptionAddress,
masm->isolate());
...and here.
https://codereview.chromium.org/240053010/diff/90001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/240053010/diff/90001/src/x64/code-stubs-x64.cc#newcode2429
src/x64/code-stubs-x64.cc:2429: // On entry to code generated by
GenerateCore, it must hold
"GenerateCore" doesn't exist any more.
https://codereview.chromium.org/240053010/diff/90001/src/x64/code-stubs-x64.cc#newcode2516
src/x64/code-stubs-x64.cc:2516: __ cmpq(r14, pending_exception_operand);
I think the x32 port requires a "cmpp" here ("p" as in "pointer size").
https://codereview.chromium.org/240053010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
