Reviewers: Michael Starzinger,
Message:
Long and boring, but mechanical... :-)
Description:
CodeStubs contain their corresponding Isolate* now. (part 1)
This is a purely mechanical change, adding an Isolate* to the CodeStub
constructor and a corresponding field plus a getter. A few methods in
CodeStub and its subclasses can be simplified now, but this is done in
a separate CL.
The underlying reason apart from simplicity is that deep down in the
call chain we need to detect if the serializer is active or not. This
information will be part of the Isolate, not a global variable with
funky synchronization primitives around it (which is fundamentally
wrong and the underlying cause for race conditions and a catch-22
during initialization).
BUG=359977
Please review this at https://codereview.chromium.org/246643014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+951, -821 lines):
M src/arm/builtins-arm.cc
M src/arm/code-stubs-arm.h
M src/arm/code-stubs-arm.cc
M src/arm/debug-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm/macro-assembler-arm.cc
M src/arm/regexp-macro-assembler-arm.cc
M src/arm/stub-cache-arm.cc
M src/arm64/builtins-arm64.cc
M src/arm64/code-stubs-arm64.h
M src/arm64/code-stubs-arm64.cc
M src/arm64/debug-arm64.cc
M src/arm64/full-codegen-arm64.cc
M src/arm64/lithium-codegen-arm64.h
M src/arm64/lithium-codegen-arm64.cc
M src/arm64/macro-assembler-arm64.cc
M src/arm64/regexp-macro-assembler-arm64.cc
M src/arm64/stub-cache-arm64.cc
M src/code-stubs.h
M src/code-stubs.cc
M src/deoptimizer.cc
M src/frames.cc
M src/heap.cc
M src/hydrogen.cc
M src/ia32/builtins-ia32.cc
M src/ia32/code-stubs-ia32.h
M src/ia32/code-stubs-ia32.cc
M src/ia32/debug-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/macro-assembler-ia32.cc
M src/ia32/stub-cache-ia32.cc
M src/ic.cc
M src/stub-cache.cc
M src/type-info.cc
M src/x64/builtins-x64.cc
M src/x64/code-stubs-x64.h
M src/x64/code-stubs-x64.cc
M src/x64/debug-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M src/x64/macro-assembler-x64.cc
M src/x64/stub-cache-x64.cc
M test/cctest/test-code-stubs-arm.cc
M test/cctest/test-code-stubs-arm64.cc
M test/cctest/test-code-stubs-ia32.cc
M test/cctest/test-code-stubs-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
