LGTM, just nits.
https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):
https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc#oldcode3787
src/arm/code-stubs-arm.cc:3787:
nit: Can we get the empty newline back for readability?
https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (left):
https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc#oldcode4318
src/arm64/code-stubs-arm64.cc:4318:
nit: Can we get the empty newline back for readability?
https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):
https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc#newcode5223
src/arm64/code-stubs-arm64.cc:5223: Handle<Object>
undefined_sentinel(isolate()->heap()->undefined_value(),
nit: I know it's not part of your change, but can we use the following
instead?
Handle<Object> undefined_sentinel =
isolate()->factory()->undefined_value();
https://codereview.chromium.org/246643014/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (left):
https://codereview.chromium.org/246643014/diff/1/src/ia32/code-stubs-ia32.cc#oldcode3669
src/ia32/code-stubs-ia32.cc:3669:
nit: Can we get the empty newline back for readability?
https://codereview.chromium.org/246643014/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (left):
https://codereview.chromium.org/246643014/diff/1/src/x64/code-stubs-x64.cc#oldcode3556
src/x64/code-stubs-x64.cc:3556:
nit: Can we get the empty newline back for readability?
https://codereview.chromium.org/246643014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
