Reviewers: jbramley,
Message:
Hi Jacob, this addresses your comments in 236633006. PTAL. Thanks!
Description:
ARM64: small fixes for ArgumentAdaptorTrampoline after r20751.
BUG=
Please review this at https://codereview.chromium.org/252483002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -2 lines):
M src/arm64/builtins-arm64.cc
Index: src/arm64/builtins-arm64.cc
diff --git a/src/arm64/builtins-arm64.cc b/src/arm64/builtins-arm64.cc
index
bada60088bb9633cb9d95fb5aaf59ad781f88731..4ff3beb185f2cfdb436bebe2a168851a0de47682
100644
--- a/src/arm64/builtins-arm64.cc
+++ b/src/arm64/builtins-arm64.cc
@@ -1415,7 +1415,6 @@ static void ArgumentAdaptorStackCheck(MacroAssembler*
masm,
// Make x10 the space we have left. The stack might already be overflowed
// here which will cause x10 to become negative.
__ Sub(x10, jssp, x10);
- __ Mov(x11, jssp);
// Check if the arguments will overflow the stack.
__ Cmp(x10, Operand(x2, LSL, kPointerSizeLog2));
__ B(le, stack_overflow);
@@ -1583,7 +1582,7 @@ void
Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) {
FrameScope frame(masm, StackFrame::MANUAL);
EnterArgumentsAdaptorFrame(masm);
__ InvokeBuiltin(Builtins::STACK_OVERFLOW, CALL_FUNCTION);
- __ Brk(0);
+ __ Unreachable();
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
