On 2014/04/24 08:39:45, jbramley wrote:
https://codereview.chromium.org/236633006/diff/10008/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):
https://codereview.chromium.org/236633006/diff/10008/src/arm64/builtins-arm64.cc#newcode1418
src/arm64/builtins-arm64.cc:1418: __ Mov(x11, jssp);
This move doesn't look necessary.
https://codereview.chromium.org/236633006/diff/10008/src/arm64/builtins-arm64.cc#newcode1586
src/arm64/builtins-arm64.cc:1586: __ Brk(0);
'__ Unreachable()' may be more appropriate.
Thanks! I uploaded fix: https://codereview.chromium.org/252483002/
https://codereview.chromium.org/236633006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
