Revision: 20971
Author: [email protected]
Date: Fri Apr 25 11:29:02 2014 UTC
Log: Preserve Smi representation of non-escaping fields.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/251493004
http://code.google.com/p/v8/source/detail?r=20971
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-escape-preserve-smi-representation.js
Modified:
/branches/bleeding_edge/src/hydrogen-escape-analysis.cc
/branches/bleeding_edge/src/hydrogen-escape-analysis.h
=======================================
--- /dev/null
+++
/branches/bleeding_edge/test/mjsunit/regress/regress-escape-preserve-smi-representation.js
Fri Apr 25 11:29:02 2014 UTC
@@ -0,0 +1,35 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function deepEquals(a, b) {
+ if (a === b) { if (a === 0) return (1 / a) === (1 / b); return true; }
+ if (typeof a != typeof b) return false;
+ if (typeof a == "number") return isNaN(a) && isNaN(b);
+ if (typeof a !== "object" && typeof a !== "function") return false;
+ if (objectClass === "RegExp") { return (a.toString() === b.toString()); }
+ if (objectClass === "Function") return false;
+ if (objectClass === "Array") {
+ var elementCount = 0;
+ if (a.length != b.length) { return false; }
+ for (var i = 0; i < a.length; i++) {
+ if (!deepEquals(a[i], b[i])) return false;
+ }
+ return true;
+ }
+}
+
+
+function __f_1(){
+ var __v_0 = [];
+ for(var i=0; i<2; i++){
+ var __v_1=[];
+ __v_0.push([])
+ deepEquals(2, __v_0.length);
+ }
+}
+__f_1();
+%OptimizeFunctionOnNextCall(__f_1);
+__f_1();
=======================================
--- /branches/bleeding_edge/src/hydrogen-escape-analysis.cc Wed Oct 16
09:16:56 2013 UTC
+++ /branches/bleeding_edge/src/hydrogen-escape-analysis.cc Fri Apr 25
11:29:02 2014 UTC
@@ -159,6 +159,23 @@
check->InsertBefore(mapcheck);
return check;
}
+
+
+// Replace a field load with a given value, forcing Smi representation if
+// necessary.
+HValue* HEscapeAnalysisPhase::NewLoadReplacement(
+ HLoadNamedField* load, HValue* load_value) {
+ HValue* replacement = load_value;
+ Representation representation = load->representation();
+ if (representation.IsSmi()) {
+ Zone* zone = graph()->zone();
+ HInstruction* new_instr =
+ HForceRepresentation::New(zone, NULL, load_value, representation);
+ new_instr->InsertAfter(load);
+ replacement = new_instr;
+ }
+ return replacement;
+}
// Performs a forward data-flow analysis of all loads and stores on the
@@ -196,10 +213,11 @@
int index = load->access().offset() / kPointerSize;
if (load->object() != allocate) continue;
ASSERT(load->access().IsInobject());
- HValue* replacement = state->OperandAt(index);
+ HValue* replacement =
+ NewLoadReplacement(load, state->OperandAt(index));
load->DeleteAndReplaceWith(replacement);
if (FLAG_trace_escape_analysis) {
- PrintF("Replacing load #%d with #%d (%s)\n", instr->id(),
+ PrintF("Replacing load #%d with #%d (%s)\n", load->id(),
replacement->id(), replacement->Mnemonic());
}
break;
=======================================
--- /branches/bleeding_edge/src/hydrogen-escape-analysis.h Mon Sep 9
09:53:58 2013 UTC
+++ /branches/bleeding_edge/src/hydrogen-escape-analysis.h Fri Apr 25
11:29:02 2014 UTC
@@ -62,6 +62,8 @@
HValue* NewMapCheckAndInsert(HCapturedObject* state, HCheckMaps*
mapcheck);
+ HValue* NewLoadReplacement(HLoadNamedField* load, HValue* load_value);
+
HCapturedObject* StateAt(HBasicBlock* block) {
return block_states_.at(block->block_id());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
