LGTM (sorry, totally fell through the cracks).
https://codereview.chromium.org/225283006/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/225283006/diff/1/src/deoptimizer.h#newcode338
src/deoptimizer.h:338: // Translate object, store the result into the
given frame slot.
nit: This does not only translate objects but also primitive values.
Maybe the three comments should read "Translate value/object, store
[...]"
https://codereview.chromium.org/225283006/diff/1/src/deoptimizer.h#newcode345
src/deoptimizer.h:345: void DoTranslateSkip(TranslationIterator*
iterator);
nit: Maybe we could call this DoTranslateObjectAndSkip?
https://codereview.chromium.org/225283006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
