Reviewers: Toon Verwaest,
Message:
Hi Toon,
Here is the revised CallICStub. It's rebased on a CL that needs to last
first,
moving the type vector to the SharedFunctionInfo. It
a) never patches
b) goes to the runtime on monomorphic miss
c) doesn't go to the runtime on megamorphic miss (unless --trace_ic is on)
d) Retrieves the vector from the frame, rather than passed in as a register.
This last change avoids performance degrades.
Sunspider string-base64 still has an issue, looking at that. So no hurry on
this
CL yet, with another to land first, thx,
--Michael
Description:
CallICStub with a "never patch" approach by default. Patching will
occur only when custom feedback needs to be gathered (future CLs).
Now rebased on https://codereview.chromium.org/254623002/, which moves the
type
feedback vector to the SharedFunctionInfo.
Please review this at https://codereview.chromium.org/247373002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1188, -659 lines):
M src/arm/builtins-arm.cc
M src/arm/code-stubs-arm.cc
M src/arm/debug-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm64/builtins-arm64.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/debug-arm64.cc
M src/arm64/full-codegen-arm64.cc
M src/arm64/lithium-codegen-arm64.cc
M src/ast.cc
M src/builtins.h
M src/builtins.cc
M src/code-stubs.h
M src/code-stubs.cc
M src/compiler.cc
M src/debug.h
M src/debug.cc
M src/factory.h
M src/factory.cc
M src/full-codegen.h
M src/ia32/builtins-ia32.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/debug-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/ic.h
M src/ic.cc
M src/liveedit.h
M src/liveedit.cc
M src/log.h
M src/log.cc
M src/objects.h
M src/objects.cc
M src/objects-inl.h
M src/objects-visiting-inl.h
M src/spaces.cc
M src/v8globals.h
M src/x64/builtins-x64.cc
M src/x64/code-stubs-x64.cc
M src/x64/debug-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M test/mjsunit/debug-liveedit-newsource.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
