https://codereview.chromium.org/257563004/diff/60001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/257563004/diff/60001/src/hydrogen.cc#newcode2633
src/hydrogen.cc:2633: HValue*
HGraphBuilder::BuildCloneShallowArrayNoElements(
On 2014/04/25 08:25:17, mvstanton wrote:
I don't like the name that much, it surprises me that a function with
them name
would leave 1/2 of the JSArray uninitialized.
Done.
https://codereview.chromium.org/257563004/diff/60001/src/hydrogen.cc#newcode2657
src/hydrogen.cc:2657: for (int i = 0; i < JSArray::kElementsOffset; i +=
kPointerSize) {
On 2014/04/25 08:25:17, mvstanton wrote:
This is simply a map store, can we eliminate the loop and just store
the map?
Done.
https://codereview.chromium.org/257563004/diff/60001/src/hydrogen.cc#newcode2658
src/hydrogen.cc:2658: if (i != JSArray::kElementsOffset) {
On 2014/04/25 08:25:17, mvstanton wrote:
As written, this check would always succeed.
Done.
https://codereview.chromium.org/257563004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
