https://codereview.chromium.org/250883002/diff/60001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/250883002/diff/60001/src/bootstrapper.cc#newcode1556
src/bootstrapper.cc:1556: enqueue_external_microtask);
On 2014/04/28 05:09:34, rafaelw wrote:
Can you please update

enqueue_external_microtask -> enqueue_microtask

and

ENQUEUE_EXTERNAL_MICROTASK -> ENQUEUE_MICROTASK

in contexts.h & execution.cc

?

Done.

https://codereview.chromium.org/250883002/diff/60001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/250883002/diff/60001/src/v8natives.js#newcode1903
src/v8natives.js:1903: delete microtaskState.queue;
On 2014/04/28 05:09:34, rafaelw wrote:
nit: assign NULL here (and check for NULL as well as UNDEFINED below).
Deleting
puts the object into dictionary storage mode.
Sorry I reverted the change by mistake. Done.

https://codereview.chromium.org/250883002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to