On 2014/04/28 12:21:10, Paweł Hajdan Jr. wrote:
https://codereview.chromium.org/230553003/diff/1/include/v8.h
File include/v8.h (left):
https://codereview.chromium.org/230553003/diff/1/include/v8.h#oldcode3962
include/v8.h:3962: // Deprecated.
On 2014/04/17 14:20:31, jochen wrote:
> On 2014/04/17 14:16:24, Paweł Hajdan Jr. wrote:
> > Wait, this did not get through V8_DEPRECATED process. Is that really
OK?
>
> There is no such process.
I'm surprised by this, could you explain more?
I can understand starting with just a // Deprecated comment as opposed to
V8_DEPRECATED so that Chromium can compile.
But then it seems the course of action would be to use V8_DEPRECATED
rather
than
removing the API immediately.
Sure, but I won't keep unused code around, and as far as I can tell, nobody
but
chrome uses it.
https://codereview.chromium.org/230553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.