One name comment, and then
LGTM.
https://codereview.chromium.org/258953009/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/258953009/diff/1/src/objects.cc#newcode6058
src/objects.cc:6058: copy =
isolate->factory()->CopyJSObjectWithMemento(object, site_to_pass);
I think this method should be called CopyJSObjectWithAllocationSite(),
because although it's true that mementos (there can be more than one
when depth > 1) may be emitted, the allocation site is really in charge.
In fact, mementos could become a thing of the past, and the tracking
mechanism becomes maintained in some other way.
https://codereview.chromium.org/258953009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
