Hey Michael,
Nice work! First round of comments.
-- Benedikt
https://codereview.chromium.org/254623002/diff/60001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/254623002/diff/60001/src/compiler.cc#newcode263
src/compiler.cc:263: feedback_vector_ =
isolate()->factory()->NewFixedArray(length, TENURED);
How about adding a factory wrapper for
Heap::AllocateFixedArrayWithFiller() and call that wrapper, i.e.
NewFixedArrayWithFiller(length, TENURED, sentinel) instead of allocating
a FixedArray filled with undefined and then overwriting undefined with
sentinel?
https://codereview.chromium.org/254623002/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/254623002/diff/60001/src/objects.cc#newcode11264
src/objects.cc:11264: void
SharedFunctionInfo::ClearTypeFeedbackInfo(Heap* heap) {
Nit: Please remove the useless Heap parameter and use GetHeap() instead.
https://codereview.chromium.org/254623002/diff/60001/src/type-info.cc
File src/type-info.cc (right):
https://codereview.chromium.org/254623002/diff/60001/src/type-info.cc#newcode46
src/type-info.cc:46: Handle<FixedArray> feedback_vector,
As discussed offline: You'll probably need to duplicate the feedback
vector here, as a GC can clear the type feedback while you are trying to
use it. And add a comment that this can be removed later, once our
crappy feedback clearing during GC is history.
https://codereview.chromium.org/254623002/diff/60001/src/typing.cc
File src/typing.cc (right):
https://codereview.chromium.org/254623002/diff/60001/src/typing.cc#newcode44
src/typing.cc:44:
Handle<Context>(info->closure()->context()->native_context()),
Nit: Use handle() instead of Handle<T>()
https://codereview.chromium.org/254623002/diff/60001/test/cctest/test-compiler.cc
File test/cctest/test-compiler.cc (right):
https://codereview.chromium.org/254623002/diff/60001/test/cctest/test-compiler.cc#newcode323
test/cctest/test-compiler.cc:323:
CHECK(f->shared()->has_deoptimization_support());
Nit: Please also CHECK() that f is actually optimized at this point.
https://codereview.chromium.org/254623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
