LGTM with comments.
https://codereview.chromium.org/256743004/diff/60001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/256743004/diff/60001/src/mark-compact.cc#newcode3711
src/mark-compact.cc:3711:
nit: Two lines of white-space ought'a be enough for everybody.
https://codereview.chromium.org/256743004/diff/60001/src/mark-compact.h
File src/mark-compact.h (right):
https://codereview.chromium.org/256743004/diff/60001/src/mark-compact.h#newcode730
src/mark-compact.h:730: void UnlinkEvacuationCandidates();
nit: The unlink method is gone, let's remove the declaration.
https://codereview.chromium.org/256743004/diff/60001/src/mark-compact.h#newcode731
src/mark-compact.h:731: void ReleaseEvacuationCandidates();
nit: The release method could be moved to near the others for
readability.
https://codereview.chromium.org/256743004/diff/100001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/256743004/diff/100001/src/mark-compact.cc#newcode4157
src/mark-compact.cc:4157: space->ClearStats();
As discussed offline: Can we play it safe and set the
"end_of_unswept_pages" to a safe value here? I agree that the first page
should always be swept (and not evacuated), but being defensive is
better.
https://codereview.chromium.org/256743004/diff/100001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/256743004/diff/100001/src/spaces.h#newcode1975
src/spaces.h:1975: Page* end_of_unswept_pages_;
Can we have a comment explaining the semantics of this field?
https://codereview.chromium.org/256743004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
