LGTM!
https://codereview.chromium.org/259233002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/259233002/diff/1/BUILD.gn#newcode35
BUILD.gn:35: # TODO(jochen): Do actions need visibility settings as
well?
I think it's a good idea. I'd just use ":*" for everything you don't
want external targets to depend on.
https://codereview.chromium.org/259233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
