LGTM.
https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js
File test/mjsunit/regress/supported-locales-of.js (right):
https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js#newcode1
test/mjsunit/regress/supported-locales-of.js:1: // Copyright 2014 the V8
project authors. All rights reserved.
nit: The name of the test-case is misleading as it tests more than the
name indicates. How do you feel about adding it to the
"regress-builtinbust-[n].js" family?
https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js#newcode19
test/mjsunit/regress/supported-locales-of.js:19:
nit: Let's drop one of the two empty newlines.
https://codereview.chromium.org/253903003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
