I think this is going in the right direction, cool stuff.
If performance is not *significantly* negatively impacted we should get rid
of
the macros.
https://codereview.chromium.org/253293003/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/253293003/diff/1/src/heap.h#newcode686
src/heap.h:686: static inline Object* read_field(HeapObject* p, int
offset);
Our INLINE macro may force inlining of these functions.
https://codereview.chromium.org/253293003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/253293003/diff/1/src/objects-inl.h#newcode99
src/objects-inl.h:99: #define SYNCHRONIZED_SMI_ACCESSORS(holder, name,
offset) \
The synchronized accessors should also live in heap, i.e., all methods
using them should be part of heap.
https://codereview.chromium.org/253293003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
