Reviewers: mcilroy, Michael Starzinger,

Description:
When maximum space size flags are set, overwrite the resource constraints.

BUG=

Please review this at https://codereview.chromium.org/262653002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+11, -0 lines):
  M src/api.cc


Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index ab4ded2472971ea519ba412b40c16bfc39804ad1..7adf987692eaff1b01f151f03e1812aed3a8680e 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -461,6 +461,17 @@ void ResourceConstraints::ConfigureDefaults(uint64_t physical_memory,

   set_max_available_threads(i::Max(i::Min(number_of_processors, 4u), 1u));

+  if (i::FLAG_max_new_space_size > 0) {
+ set_max_new_space_size(i::FLAG_max_new_space_size * i::Heap::kLumpOfMemory);
+  }
+  if (i::FLAG_max_old_space_size > 0) {
+ set_max_old_space_size(i::FLAG_max_old_space_size * i::Heap::kLumpOfMemory);
+  }
+  if (i::FLAG_max_executable_size > 0) {
+    set_max_executable_size(
+        i::FLAG_max_executable_size * i::Heap::kLumpOfMemory);
+  }
+
   if (virtual_memory_limit > 0 && i::kIs64BitArch) {
// Reserve no more than 1/8 of the memory for the code range, but at most
     // 512 MB.


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to