https://codereview.chromium.org/260723002/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/260723002/diff/1/src/debug.cc#newcode1334
src/debug.cc:1334: current_promise_catch_handler_ = NULL;
Are we sure that PromiseHandle can never be reentered recursively?
https://codereview.chromium.org/260723002/diff/1/src/debug.h
File src/debug.h (right):
https://codereview.chromium.org/260723002/diff/1/src/debug.h#newcode239
src/debug.h:239: void PromiseHandlePrologue(Handle<JSFunction> promise);
Perhaps name the argument get_promise for clarity.
https://codereview.chromium.org/260723002/diff/1/src/promise.js
File src/promise.js (left):
https://codereview.chromium.org/260723002/diff/1/src/promise.js#oldcode320
src/promise.js:320: function GetPromiseStatus(promise) {
As discussed offline, I'd prefer to keep the accessors.
https://codereview.chromium.org/260723002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/260723002/diff/1/src/promise.js#newcode44
src/promise.js:44: %DebugPromiseHandleEpilogue();
Put his in 'finally' clause (also below).
https://codereview.chromium.org/260723002/diff/1/src/promise.js#newcode180
src/promise.js:180: %DebugPromiseHandlePrologue(function() { return
deferred.promise });
It's a bit weird that the prologue is executed twice. Doesn't it have to
match up with the Epilogue?
https://codereview.chromium.org/260723002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
