lgtm with a nit.
https://codereview.chromium.org/255333004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/255333004/diff/1/src/runtime.cc#newcode961
src/runtime.cc:961: RUNTIME_ASSERT(arrayId >= 1 && arrayId <= 9);
Add FIRST_ and LAST_ to TypedArrayId enum instead of these comments
https://codereview.chromium.org/255333004/diff/1/src/runtime.cc#newcode1046
src/runtime.cc:1046: RUNTIME_ASSERT(arrayId >= 1 && arrayId <= 9);
Ditto.
https://codereview.chromium.org/255333004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
