Addressed the nits. Since the code in base.js is taken from the original mjsunit/fuzz-natives* tests, I'd prefer to just keep the logic we have for now, unless there's aconcrete reason to change something. I've added a header comment to sum up our
feelings :-)
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js File test/fuzz-natives/base.js (right): https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode32 test/fuzz-natives/base.js:32: return new Function(args.join(", "), On 2014/04/29 15:51:53, Michael Achenbach wrote:
args.join(", ") == argsStr
Done. https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode67 test/fuzz-natives/base.js:67: kArgObjects : kArgObjects-kOnManyArgumentsRemove; On 2014/04/29 15:51:53, Michael Achenbach wrote:
nit: space around -
Done. https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode75 test/fuzz-natives/base.js:75: var hasMore = false; On 2014/04/29 15:51:53, Michael Achenbach wrote:
var hasMore exists in the outer scope. Remove var?
Done. https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/testcfg.py File test/fuzz-natives/testcfg.py (right): https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/testcfg.py#newcode28 test/fuzz-natives/testcfg.py:28: if output.exit_code != 0: On 2014/04/29 15:51:53, Michael Achenbach wrote:
If the command fails, the test driver would rather quietly pass with
no tests...
But no need to do something about that now... I assume in release
mode, the
command returns nothing?
%ListNatives() isn't available in Release; the try..catch ensures that the command silently terminates with empty output. You can have an assert instead of the empty result, it most likely won't ever make a difference in practice. https://codereview.chromium.org/252143002/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
