LGTM with comment.
https://codereview.chromium.org/264563003/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/264563003/diff/1/src/heap.cc#newcode6265
src/heap.cc:6265: String* internalized_string;
Could we add a DisallowHeapAllocation scope in each of those methods?
Neither would work if GC happened.
https://codereview.chromium.org/264563003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
