[v8-dev] Limit old space size in test which require a large new space. (issue 265673003)

Wed, 30 Apr 2014 11:54:51 -0700 

Reviewers: Michael Starzinger,

Message:
TBR

Description:
Limit old space size in test which require a large new space.

BUG=

Please review this at https://codereview.chromium.org/265673003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+20, -12 lines):
  M test/mjsunit/binary-op-newspace.js
  M test/mjsunit/compiler/math-floor-global.js
  M test/mjsunit/compiler/math-floor-local.js
  M test/mjsunit/define-property-gc.js
  M test/mjsunit/math-abs.js
  M test/mjsunit/math-floor-part1.js
  M test/mjsunit/math-floor-part2.js
  M test/mjsunit/math-floor-part3.js
  M test/mjsunit/math-floor-part4.js
  M test/mjsunit/regress/regress-1708.js
  M test/mjsunit/regress/regress-99167.js
  M test/mjsunit/regress/regress-create-exception.js


Index: test/mjsunit/binary-op-newspace.js
diff --git a/test/mjsunit/binary-op-newspace.js b/test/mjsunit/binary-op-newspace.js index e3341c4a7a7003c9faddefdeb9de21ea93796d3f..9fb36234576f34464e149e46ab294e7e68ac8b46 100644 
--- a/test/mjsunit/binary-op-newspace.js
+++ b/test/mjsunit/binary-op-newspace.js
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=256 --noopt
+// Flags: --max-old-space-size=256 --max-new-space-size=256 --noopt

 // Check that a mod where the stub code hits a failure in heap number
 // allocation still works.
Index: test/mjsunit/compiler/math-floor-global.js
diff --git a/test/mjsunit/compiler/math-floor-global.js b/test/mjsunit/compiler/math-floor-global.js index 3b9d1254537dce8d3dfb8a09ca0deacc278d57ff..d8b85b9751088cbd1f1a4ed01f1a4a742e3f7daf 100644 
--- a/test/mjsunit/compiler/math-floor-global.js
+++ b/test/mjsunit/compiler/math-floor-global.js
@@ -25,7 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=128 --allow-natives-syntax
+// Flags: --max-old-space-size=256 --max-new-space-size=128
+// Flags: --allow-natives-syntax

 // Test inlining of Math.floor when assigned to a global.
 var flo = Math.floor;
Index: test/mjsunit/compiler/math-floor-local.js
diff --git a/test/mjsunit/compiler/math-floor-local.js b/test/mjsunit/compiler/math-floor-local.js index fef3347e800bf083069a32106d12fa65467b6fc2..69215df4664575d9918077dcbf3b169e7f156f9a 100644 
--- a/test/mjsunit/compiler/math-floor-local.js
+++ b/test/mjsunit/compiler/math-floor-local.js
@@ -25,7 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=128 --allow-natives-syntax
+// Flags: --max-old-space-size=256 --max-new-space-size=128
+// Flags: --allow-natives-syntax

 // Test inlining of Math.floor when assigned to a local.
 var test_id = 0;
Index: test/mjsunit/define-property-gc.js
diff --git a/test/mjsunit/define-property-gc.js b/test/mjsunit/define-property-gc.js index b38164d0f40b52c685448a7c2d84ced2aa7187f2..47d28095dad2503a9187377d43cda3833cc70140 100644 
--- a/test/mjsunit/define-property-gc.js
+++ b/test/mjsunit/define-property-gc.js
@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 // Tests the handling of GC issues in the defineProperty method.
-// Flags: --max-new-space-size=256
+// Flags: --max-old-space-size=256 --max-new-space-size=256

 function Regular() {
   this[0] = 0;
Index: test/mjsunit/math-abs.js
diff --git a/test/mjsunit/math-abs.js b/test/mjsunit/math-abs.js
index d6ee3f2da7853f071559cbb32911dcde3a81f506..b0647c1efec6b66a5139ef69ed2268503dc6a103 100644 
--- a/test/mjsunit/math-abs.js
+++ b/test/mjsunit/math-abs.js
@@ -25,7 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=256 --allow-natives-syntax
+// Flags: --max-old-space-size=256 --max-new-space-size=256
+// Flags: --allow-natives-syntax

 function zero() {
   var x = 0.5;
Index: test/mjsunit/math-floor-part1.js
diff --git a/test/mjsunit/math-floor-part1.js b/test/mjsunit/math-floor-part1.js index b57b3e20dc8782e6e655f0ecd4a66b572b654018..7c20aac05f05ef6f1d954bfbf3686922d8714995 100644 
--- a/test/mjsunit/math-floor-part1.js
+++ b/test/mjsunit/math-floor-part1.js
@@ -25,7 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=128 --allow-natives-syntax
+// Flags: --max-old-space-size=256 --max-new-space-size=128
+// Flags: --allow-natives-syntax

 var test_id = 0;

Index: test/mjsunit/math-floor-part2.js
diff --git a/test/mjsunit/math-floor-part2.js b/test/mjsunit/math-floor-part2.js index b6d51b2bde91265c755e17f9b5319c8ac34073aa..e54c9faf9166af73292d1c26ddba4a63860ce7f8 100644 
--- a/test/mjsunit/math-floor-part2.js
+++ b/test/mjsunit/math-floor-part2.js
@@ -25,7 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=256 --allow-natives-syntax
+// Flags: --max-old-space-size=256 --max-new-space-size=256
+// Flags: --allow-natives-syntax

 var test_id = 0;

Index: test/mjsunit/math-floor-part3.js
diff --git a/test/mjsunit/math-floor-part3.js b/test/mjsunit/math-floor-part3.js index db2592343355d8d2273a6d01424f7a6d2f5da486..d6978898a1c8a02fb1e12d557ed5e1a7e02fcd0f 100644 
--- a/test/mjsunit/math-floor-part3.js
+++ b/test/mjsunit/math-floor-part3.js
@@ -25,7 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=256 --allow-natives-syntax
+// Flags: --max-old-space-size=256 --max-new-space-size=256
+// Flags: --allow-natives-syntax

 var test_id = 0;

Index: test/mjsunit/math-floor-part4.js
diff --git a/test/mjsunit/math-floor-part4.js b/test/mjsunit/math-floor-part4.js index c63362308342270b41965a91341098b011c1354f..1c30db9d7b07c38ac0113dc87c51bdfee6c89559 100644 
--- a/test/mjsunit/math-floor-part4.js
+++ b/test/mjsunit/math-floor-part4.js
@@ -25,7 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=256 --allow-natives-syntax
+// Flags: --max-old-space-size=256 --max-new-space-size=256
+// Flags: --allow-natives-syntax

 var test_id = 0;

Index: test/mjsunit/regress/regress-1708.js
diff --git a/test/mjsunit/regress/regress-1708.js b/test/mjsunit/regress/regress-1708.js index 76f97682236e4cf15166eb816ba7e315b537c0b6..8fabbc653ec74886589ee8b2a4194e841e04a42e 100644 
--- a/test/mjsunit/regress/regress-1708.js
+++ b/test/mjsunit/regress/regress-1708.js
@@ -32,7 +32,8 @@
 // sure that concurrent sweeping, which relies on similar assumptions
 // as lazy sweeping works correctly.

-// Flags: --expose-gc --noincremental-marking --max-new-space-size 1000
+// Flags: --expose-gc --noincremental-marking --max-new-space-size=1000
+// Flags: --max-old-space-size=256

 (function() {
   var head = new Array(1);
Index: test/mjsunit/regress/regress-99167.js
diff --git a/test/mjsunit/regress/regress-99167.js b/test/mjsunit/regress/regress-99167.js index 5053ae5d24f5766e6d3116456fae305427196be5..f29fcac7fba60898f146d720efa5f71e97f23a1d 100644 
--- a/test/mjsunit/regress/regress-99167.js
+++ b/test/mjsunit/regress/regress-99167.js
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --expose-gc --max-new-space-size=1024
+// Flags: --expose-gc --max-old-space-size=256 --max-new-space-size=1024

 eval("function Node() { this.a = 1; this.a = 3; }");
 new Node;
Index: test/mjsunit/regress/regress-create-exception.js
diff --git a/test/mjsunit/regress/regress-create-exception.js b/test/mjsunit/regress/regress-create-exception.js index d3face9f3736e0b3d067461cdfb9cf30883ffb1a..7f674faa2034f9b2359d63582bd72fdf80a42405 100644 
--- a/test/mjsunit/regress/regress-create-exception.js
+++ b/test/mjsunit/regress/regress-create-exception.js
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-new-space-size=256
+// Flags: --max-old-space-size=256 --max-new-space-size=256
 "use strict";

 // Check for GC bug constructing exceptions.


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to