[v8-dev] Remove max space limits in tests. (issue 263703003)

Wed, 30 Apr 2014 12:32:28 -0700 

Reviewers: Michael Starzinger,

Message:
Hi Michael,
since we were running these tests without these limits for months (because we ignored the max limits flags) and I cannot think about a reason why the limits 
make sense, I am removing them from the tests.

[email protected]

Description:
Remove max space limits in tests.

BUG=

Please review this at https://codereview.chromium.org/263703003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+3, -13 lines):
  M test/mjsunit/binary-op-newspace.js
  M test/mjsunit/compiler/math-floor-global.js
  M test/mjsunit/compiler/math-floor-local.js
  M test/mjsunit/define-property-gc.js
  M test/mjsunit/math-abs.js
  M test/mjsunit/math-floor-part1.js
  M test/mjsunit/math-floor-part2.js
  M test/mjsunit/math-floor-part3.js
  M test/mjsunit/math-floor-part4.js
  M test/mjsunit/regress/regress-1708.js
  M test/mjsunit/regress/regress-99167.js
  M test/mjsunit/regress/regress-create-exception.js


Index: test/mjsunit/binary-op-newspace.js
diff --git a/test/mjsunit/binary-op-newspace.js b/test/mjsunit/binary-op-newspace.js index 9fb36234576f34464e149e46ab294e7e68ac8b46..b47fcf6f59b1f8f7fc640cf309377a040e265f88 100644 
--- a/test/mjsunit/binary-op-newspace.js
+++ b/test/mjsunit/binary-op-newspace.js
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=256 --noopt
+// Flags: --noopt

 // Check that a mod where the stub code hits a failure in heap number
 // allocation still works.
Index: test/mjsunit/compiler/math-floor-global.js
diff --git a/test/mjsunit/compiler/math-floor-global.js b/test/mjsunit/compiler/math-floor-global.js index d8b85b9751088cbd1f1a4ed01f1a4a742e3f7daf..71b8054a3238a7a3f076854de7b5a4670d4d0ee3 100644 
--- a/test/mjsunit/compiler/math-floor-global.js
+++ b/test/mjsunit/compiler/math-floor-global.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=128
 // Flags: --allow-natives-syntax

 // Test inlining of Math.floor when assigned to a global.
Index: test/mjsunit/compiler/math-floor-local.js
diff --git a/test/mjsunit/compiler/math-floor-local.js b/test/mjsunit/compiler/math-floor-local.js index 69215df4664575d9918077dcbf3b169e7f156f9a..58e082c7b1bf2f4ba7c45ca0c5a163bce0918631 100644 
--- a/test/mjsunit/compiler/math-floor-local.js
+++ b/test/mjsunit/compiler/math-floor-local.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=128
 // Flags: --allow-natives-syntax

 // Test inlining of Math.floor when assigned to a local.
Index: test/mjsunit/define-property-gc.js
diff --git a/test/mjsunit/define-property-gc.js b/test/mjsunit/define-property-gc.js index 47d28095dad2503a9187377d43cda3833cc70140..0b5d06c751da973062519e50a46ecc54dc3a169d 100644 
--- a/test/mjsunit/define-property-gc.js
+++ b/test/mjsunit/define-property-gc.js
@@ -26,7 +26,6 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 // Tests the handling of GC issues in the defineProperty method.
-// Flags: --max-old-space-size=256 --max-new-space-size=256

 function Regular() {
   this[0] = 0;
Index: test/mjsunit/math-abs.js
diff --git a/test/mjsunit/math-abs.js b/test/mjsunit/math-abs.js
index b0647c1efec6b66a5139ef69ed2268503dc6a103..dfe4f3fae2f4c272c6599d6b4d46df82de297f94 100644 
--- a/test/mjsunit/math-abs.js
+++ b/test/mjsunit/math-abs.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=256
 // Flags: --allow-natives-syntax

 function zero() {
Index: test/mjsunit/math-floor-part1.js
diff --git a/test/mjsunit/math-floor-part1.js b/test/mjsunit/math-floor-part1.js index f467913cc676751da097e73cdb673100df73aa81..c75e10fc7c67c312de3e4669496da3daf1709ba2 100644 
--- a/test/mjsunit/math-floor-part1.js
+++ b/test/mjsunit/math-floor-part1.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=128
 // Flags: --allow-natives-syntax

 var test_id = 0;
Index: test/mjsunit/math-floor-part2.js
diff --git a/test/mjsunit/math-floor-part2.js b/test/mjsunit/math-floor-part2.js index 5cc349a3f41d8e8f7e4c47bf63f7c396ff949c51..d34bfbd8bedf98c35451e1edfcc02b1280c1850e 100644 
--- a/test/mjsunit/math-floor-part2.js
+++ b/test/mjsunit/math-floor-part2.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=256
 // Flags: --allow-natives-syntax

 var test_id = 0;
Index: test/mjsunit/math-floor-part3.js
diff --git a/test/mjsunit/math-floor-part3.js b/test/mjsunit/math-floor-part3.js index 65fbbd2993385ed3dba7494fa40efed464c00d3e..70eb2c67efdd07ea677de49b26a09972290d630b 100644 
--- a/test/mjsunit/math-floor-part3.js
+++ b/test/mjsunit/math-floor-part3.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=256
 // Flags: --allow-natives-syntax

 var test_id = 0;
Index: test/mjsunit/math-floor-part4.js
diff --git a/test/mjsunit/math-floor-part4.js b/test/mjsunit/math-floor-part4.js index b96c62e6690109da386001bf8adc659839cbc6be..e9a752e7d40c993f78b48ea8491a3fd0c904fb0c 100644 
--- a/test/mjsunit/math-floor-part4.js
+++ b/test/mjsunit/math-floor-part4.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=256
 // Flags: --allow-natives-syntax

 var test_id = 0;
Index: test/mjsunit/regress/regress-1708.js
diff --git a/test/mjsunit/regress/regress-1708.js b/test/mjsunit/regress/regress-1708.js index 8fabbc653ec74886589ee8b2a4194e841e04a42e..7f36ce54a592ba8f906c559aa3837d580ceec7e4 100644 
--- a/test/mjsunit/regress/regress-1708.js
+++ b/test/mjsunit/regress/regress-1708.js
@@ -32,8 +32,7 @@
 // sure that concurrent sweeping, which relies on similar assumptions
 // as lazy sweeping works correctly.

-// Flags: --expose-gc --noincremental-marking --max-new-space-size=1000
-// Flags: --max-old-space-size=256
+// Flags: --expose-gc --noincremental-marking

 (function() {
   var head = new Array(1);
Index: test/mjsunit/regress/regress-99167.js
diff --git a/test/mjsunit/regress/regress-99167.js b/test/mjsunit/regress/regress-99167.js index f29fcac7fba60898f146d720efa5f71e97f23a1d..2583c125f87bec56a11545a1f1f21efdbeb93298 100644 
--- a/test/mjsunit/regress/regress-99167.js
+++ b/test/mjsunit/regress/regress-99167.js
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --expose-gc --max-old-space-size=256 --max-new-space-size=1024
+// Flags: --expose-gc

 eval("function Node() { this.a = 1; this.a = 3; }");
 new Node;
Index: test/mjsunit/regress/regress-create-exception.js
diff --git a/test/mjsunit/regress/regress-create-exception.js b/test/mjsunit/regress/regress-create-exception.js index 7f674faa2034f9b2359d63582bd72fdf80a42405..f7393e1162586a75fd076e2ae350e813b217c7b0 100644 
--- a/test/mjsunit/regress/regress-create-exception.js
+++ b/test/mjsunit/regress/regress-create-exception.js
@@ -25,7 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --max-old-space-size=256 --max-new-space-size=256
 "use strict";

 // Check for GC bug constructing exceptions.


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to