Reviewers: ulan,
Message:
I don't think this should affect the bots, but please let me know if the
bots
only include platform-9 for some reason. PTAL, thanks.
Description:
[Android]: Update Makefile.android to use platform-14 as minimum.
The version of the NDK in Chromium only has platform/android-14 and above
(since Chrome only supports API 14 and above). To make it easier for
developers to use the Chromium NDK to build V8, this CL updates the default
platform version to 14.
Please review this at https://codereview.chromium.org/267873002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M Makefile.android
Index: Makefile.android
diff --git a/Makefile.android b/Makefile.android
index
b3a3a152d4faffab9e82ef326e507ac865a79dce..396b58d7444d974330511f1f4afe7ad30612788f
100644
--- a/Makefile.android
+++ b/Makefile.android
@@ -47,7 +47,7 @@ else
endif
ifeq ($(ARCH), android_arm)
- DEFINES = target_arch=arm v8_target_arch=arm android_target_arch=arm
android_target_platform=9
+ DEFINES = target_arch=arm v8_target_arch=arm android_target_arch=arm
android_target_platform=14
DEFINES += arm_neon=0 arm_version=7
TOOLCHAIN_ARCH = arm-linux-androideabi
TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH)
@@ -60,7 +60,7 @@ else
TOOLCHAIN_VER = 4.8
else
ifeq ($(ARCH), android_mipsel)
- DEFINES = target_arch=mipsel v8_target_arch=mipsel
android_target_platform=9
+ DEFINES = target_arch=mipsel v8_target_arch=mipsel
android_target_platform=14
DEFINES += android_target_arch=mips mips_arch_variant=mips32r2
TOOLCHAIN_ARCH = mipsel-linux-android
TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH)
@@ -68,7 +68,7 @@ else
else
ifeq ($(ARCH), android_ia32)
- DEFINES = target_arch=ia32 v8_target_arch=ia32
android_target_arch=x86 android_target_platform=9
+ DEFINES = target_arch=ia32 v8_target_arch=ia32
android_target_arch=x86 android_target_platform=14
TOOLCHAIN_ARCH = x86
TOOLCHAIN_PREFIX = i686-linux-android
TOOLCHAIN_VER = 4.6
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
