lgtm with type nit (no need for a void*)
https://codereview.chromium.org/263933002/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/263933002/diff/1/include/v8.h#newcode4125
include/v8.h:4125: void* internal_;
This can just be "v8::internal::Isolate* isolate_", there's already at
least one such usage in this header (in TryCatch).
https://codereview.chromium.org/263933002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
