Revision: 21137
Author: [email protected]
Date: Mon May 5 09:52:03 2014 UTC
Log: Inlined IsFoundByRuntimeProbingOnly.
It is only used internally at a single place.
[email protected]
Review URL: https://codereview.chromium.org/265243004
http://code.google.com/p/v8/source/detail?r=21137
Modified:
/branches/bleeding_edge/src/arm/assembler-arm.h
/branches/bleeding_edge/src/arm64/cpu-arm64.h
/branches/bleeding_edge/src/ia32/assembler-ia32.h
/branches/bleeding_edge/src/mips/assembler-mips.h
/branches/bleeding_edge/src/x64/assembler-x64.h
=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm.h Wed Apr 30 09:50:58
2014 UTC
+++ /branches/bleeding_edge/src/arm/assembler-arm.h Mon May 5 09:52:03
2014 UTC
@@ -69,16 +69,12 @@
ASSERT(initialized_);
return Check(f, supported_);
}
-
- static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
- ASSERT(initialized_);
- return Check(f, found_by_runtime_probing_only_);
- }
static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
return Check(f, cross_compile_) ||
(IsSupported(f) &&
- (!Serializer::enabled(isolate) |
| !IsFoundByRuntimeProbingOnly(f)));
+ !(Serializer::enabled(isolate) &&
+ Check(f, found_by_runtime_probing_only_)));
}
static unsigned cache_line_size() { return cache_line_size_; }
=======================================
--- /branches/bleeding_edge/src/arm64/cpu-arm64.h Fri May 2 12:35:51 2014
UTC
+++ /branches/bleeding_edge/src/arm64/cpu-arm64.h Mon May 5 09:52:03 2014
UTC
@@ -28,15 +28,9 @@
return false;
};
- static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
- ASSERT(initialized_);
- // There are no optional features for ARM64.
- return false;
- }
-
+ // There are no optional features for ARM64.
static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
- return (IsSupported(f) &&
- (!Serializer::enabled(isolate) |
| !IsFoundByRuntimeProbingOnly(f)));
+ return IsSupported(f);
}
// I and D cache line size in bytes.
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32.h Wed Apr 30 09:50:58
2014 UTC
+++ /branches/bleeding_edge/src/ia32/assembler-ia32.h Mon May 5 09:52:03
2014 UTC
@@ -542,16 +542,12 @@
if (f == CMOV && !FLAG_enable_cmov) return false;
return Check(f, supported_);
}
-
- static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
- ASSERT(initialized_);
- return Check(f, found_by_runtime_probing_only_);
- }
static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
return Check(f, cross_compile_) ||
(IsSupported(f) &&
- (!Serializer::enabled(isolate) |
| !IsFoundByRuntimeProbingOnly(f)));
+ !(Serializer::enabled(isolate) &&
+ Check(f, found_by_runtime_probing_only_)));
}
static bool VerifyCrossCompiling() {
=======================================
--- /branches/bleeding_edge/src/mips/assembler-mips.h Wed Apr 30 09:50:58
2014 UTC
+++ /branches/bleeding_edge/src/mips/assembler-mips.h Mon May 5 09:52:03
2014 UTC
@@ -435,16 +435,12 @@
ASSERT(initialized_);
return Check(f, supported_);
}
-
- static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
- ASSERT(initialized_);
- return Check(f, found_by_runtime_probing_only_);
- }
static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
return Check(f, cross_compile_) ||
(IsSupported(f) &&
- (!Serializer::enabled(isolate) |
| !IsFoundByRuntimeProbingOnly(f)));
+ !(Serializer::enabled(isolate) &&
+ Check(f, found_by_runtime_probing_only_)));
}
static bool VerifyCrossCompiling() {
=======================================
--- /branches/bleeding_edge/src/x64/assembler-x64.h Wed Apr 30 09:50:58
2014 UTC
+++ /branches/bleeding_edge/src/x64/assembler-x64.h Mon May 5 09:52:03
2014 UTC
@@ -462,16 +462,12 @@
if (f == SAHF && !FLAG_enable_sahf) return false;
return Check(f, supported_);
}
-
- static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
- ASSERT(initialized_);
- return Check(f, found_by_runtime_probing_only_);
- }
static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
return Check(f, cross_compile_) ||
(IsSupported(f) &&
- (!Serializer::enabled(isolate) |
| !IsFoundByRuntimeProbingOnly(f)));
+ !(Serializer::enabled(isolate) &&
+ Check(f, found_by_runtime_probing_only_)));
}
static bool VerifyCrossCompiling() {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
