Reviewers: dcarney,
Message:
dcarney@, ptal, jochen@, fyi.
Let's stop the symbol data madness now!
Some measurements on mobile. These were done with parser shell.
Data set 1 (20 M, contains some lazy functions).
Baseline cold: ~8400 ms
Baseline warm: ~6000 ms
Without symbol data cold: ~7000 ms
Without symbol data warm: ~5800 ms (*)
(*) This is less than cold, because we can skip over lazy functions.
Data set 2 (2.7 M, artificially made non-lazy to make it contain lots of
symbols):
Baseline cold: ~ 1700 ms
Baseline warm: ~ 1300 ms
Without symbol data cold: ~1300 ms
Without symbol data warm: ~1300 ms (*)
This is same than the cold time, because there are no lazy functions we can
skip
over.
Description:
Remove symbol preparse data altogether.
Removing it seems to be a clear win on mobile: producing symbol data makes
cold
parsing 20-30% slower, and having symbol data doesn't make warm parsing any
faster.
Notes:
- V8 used to produce symbol data, but because of a bug, it was never used
until
recently. (See fix https://codereview.chromium.org/172753002 which takes the
symbol data into use again.)
- On desktop, warm parsing is faster if we have symbol data, and producing
it
during cold parsing doesn't make parsing substantially slower. However, this
doesn't seem to be the case on mobile.
- The preparse data (cached data) will now contain only the positions of the
lazy functions.
BUG=
Please review this at https://codereview.chromium.org/261273003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+18, -320 lines):
M src/parser.h
M src/parser.cc
M src/preparse-data.h
M src/preparse-data.cc
M src/preparse-data-format.h
M src/scanner.h
M src/scanner.cc
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
