lgtm with comments:
https://codereview.chromium.org/263083008/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/263083008/diff/1/src/factory.cc#newcode1210
src/factory.cc:1210: Handle<Context>
context(isolate()->context()->native_context());
Does it make sense to add ASSERT(info->strict_mode() == SLOPPY); here to
guarantee that the info is in sync with the map?
https://codereview.chromium.org/263083008/diff/1/src/factory.cc#newcode1226
src/factory.cc:1226: Handle<Context>
context(isolate()->context()->native_context());
... and here?
https://codereview.chromium.org/263083008/diff/1/src/factory.cc#newcode1347
src/factory.cc:1347: Handle<Map> map = MapForNewFunction(isolate(),
info);
Since this is the only caller of MapForNewFunction() and the function
itself if pretty small consider inlining it.
https://codereview.chromium.org/263083008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
