Reviewers: Yang,
Message:
Turns out that having dead code in the code-base is a bad idea. The
--log-regexp
feature is broken for several reasons:
1) Some mutex assertions during log-printing (not fixed by this CL)
2) MacroAssembler::CallRuntime is a NOP when called with wrong number of
arguments.
3) MacroAssembler::IllegalOperation actually only returns undefined, but
doesn't
report illegal operations in any way.
4) Optimized code already ignores %_Log calls.
This amount of breakage leads me to believe that %_Log isn't too popular and
hence I propose to remove (4) from the code-base. This CL also fixes (2) and
removes (3) to avoid future surprises.
Description:
Remove broken %_Log functionality.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/265283007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -212 lines):
M src/arm/full-codegen-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm64/full-codegen-arm64.cc
M src/arm64/macro-assembler-arm64.cc
M src/codegen.h
M src/codegen.cc
M src/hydrogen.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/macro-assembler-ia32.h
M src/ia32/macro-assembler-ia32.cc
M src/mips/full-codegen-mips.cc
M src/mips/macro-assembler-mips.h
M src/mips/macro-assembler-mips.cc
M src/regexp.js
M src/runtime.h
M src/string.js
M src/x64/full-codegen-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
