https://codereview.chromium.org/268483002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (left):
https://codereview.chromium.org/268483002/diff/1/src/arm64/lithium-codegen-arm64.cc#oldcode5178
src/arm64/lithium-codegen-arm64.cc:5178:
ASSERT(instr->hydrogen()->elements_kind() == FAST_SMI_ELEMENTS);
On 2014/05/05 08:21:21, ulan wrote:
Can we keep these two asserts?
Done.
https://codereview.chromium.org/268483002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/268483002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode3442
src/arm64/lithium-codegen-arm64.cc:3442: bool int32_and_fast_smi =
representation.IsInteger32() &&
On 2014/05/05 08:21:21, ulan wrote:
representation.IsInteger32() should imply
(instr->hydrogen()->elements_kind() ==
FAST_SMI_ELEMENTS)
Done.
https://codereview.chromium.org/268483002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode3523
src/arm64/lithium-codegen-arm64.cc:3523: if
(representation.IsInteger32() &&
On 2014/05/05 08:21:21, ulan wrote:
representation.IsInteger32() should imply
(instr->hydrogen()->elements_kind() ==
FAST_SMI_ELEMENTS)
Could you instead of checking elements_kind add
ASSERT(instr->hydrogen()->elements_kind() == FAST_SMI_ELEMENTS);
in this branch?
Done.
https://codereview.chromium.org/268483002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode5191
src/arm64/lithium-codegen-arm64.cc:5191:
(instr->hydrogen()->elements_kind() == FAST_SMI_ELEMENTS)) {
On 2014/05/05 08:21:21, ulan wrote:
representation.IsInteger32() should imply
(instr->hydrogen()->elements_kind() ==
FAST_SMI_ELEMENTS)
Done.
https://codereview.chromium.org/268483002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode5219
src/arm64/lithium-codegen-arm64.cc:5219: __ Add(element_addr,
store_base, mem_op.OffsetAsOperand());
On 2014/05/05 08:21:21, ulan wrote:
Using mem_op.base() instead of store_base would be less fragile.
Done.
https://codereview.chromium.org/268483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
