On 2014/05/06 13:17:51, Jakob wrote:
LGTM with nits.
https://codereview.chromium.org/264233005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/264233005/diff/1/src/api.cc#newcode6467
src/api.cc:6467: reinterpret_cast<i::Isolate*>(
nit: I find this line break confusing. Suggestion: pull out i_isolate like
CancelTerminateExecution below does it.
https://codereview.chromium.org/264233005/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/264233005/diff/1/src/debug.cc#newcode3523
src/debug.cc:3523: // Request ebug break when leaving the last debugger
entry
nit: s/ebug/debug/
Thanks for the review. Uploaded new patch set. Landing once tree open.
https://codereview.chromium.org/264233005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
