Reviewers: Hannes Payer,
Description:
Make new space iterable for --log-gc and --heap-stats options
[email protected]
BUG=370827
TEST=test/mjsunit/regress/regress-370827.js
LOG=N
Please review this at https://codereview.chromium.org/272503005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -10 lines):
M src/hydrogen-instructions.cc
A + test/mjsunit/regress/regress-370827.js
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
d13b7ee70ceccacb9f2973a69b85caf5639366a4..9392c4288575990c2b83279446ee5baf10a9e826
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -3819,7 +3819,8 @@ bool HAllocate::HandleSideEffectDominator(GVNFlag
side_effect,
dominator_allocate->UpdateSize(new_dominator_size_constant);
#ifdef VERIFY_HEAP
- if (FLAG_verify_heap && dominator_allocate->IsNewSpaceAllocation()) {
+ if ((FLAG_verify_heap || FLAG_log_gc || FLAG_heap_stats) &&
+ dominator_allocate->IsNewSpaceAllocation()) {
dominator_allocate->MakePrefillWithFiller();
} else {
// TODO(hpayer): This is a short-term hack to make allocation mementos
Index: test/mjsunit/regress/regress-370827.js
diff --git
a/test/mjsunit/regress/regress-no-dummy-use-for-arguments-object.js
b/test/mjsunit/regress/regress-370827.js
similarity index 55%
copy from test/mjsunit/regress/regress-no-dummy-use-for-arguments-object.js
copy to test/mjsunit/regress/regress-370827.js
index
658d776ea3b80cd00d256a5514603bdb3df1f179..5536d5196b569135266257a34a1055c0b2d28292
100644
--- a/test/mjsunit/regress/regress-no-dummy-use-for-arguments-object.js
+++ b/test/mjsunit/regress/regress-370827.js
@@ -2,20 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --allow-natives-syntax
+// Flags: --allow-natives-syntax --expose-gc --heap-stats
-function g() {
- arguments.length;
-}
-
-var global = "";
+function g(dummy, x) {
+ var start = "";
+ if (x) { start = x + " - "; }
+ start = start + "array length";
+};
function f() {
- global.dummy = this;
- g({});
+ gc();
+ g([0.1]);
}
f();
-f();
%OptimizeFunctionOnNextCall(f);
f();
+f();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
