lgtm with comments that you can ignore if they do not make sense:
https://codereview.chromium.org/261963003/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/261963003/diff/1/src/bootstrapper.cc#newcode1574
src/bootstrapper.cc:1574: isolate()->initial_object_prototype(),
Builtins::kInternalArrayCode);
Here we skip instance_class_name initialization for InternalArray and
InternalPackedArray. Seems ok, but I'm not fully sure.
https://codereview.chromium.org/261963003/diff/1/src/bootstrapper.cc#newcode1577
src/bootstrapper.cc:1577:
Accessors::FunctionSetPrototype(array_function, prototype);
Can we pass the prototype to the InstallFunction() instead of activating
all the machinery?
https://codereview.chromium.org/261963003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
