I missed this CL while I was reviewing "270573003: Rename NewFunction
without
prototype to NewFunctionWithoutPrototype".
lgtm with nits:
https://codereview.chromium.org/264973020/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/264973020/diff/1/src/factory.cc#newcode2055
src/factory.cc:2055: int internal_field_count = 0;
Suggestion: it seems that |type| and |instance_size| are only necessary
if (!obj->remove_prototype()).
https://codereview.chromium.org/264973020/diff/1/src/factory.cc#newcode2088
src/factory.cc:2088: ? NewFunction(Factory::empty_string(), code)
I think you can omit Function:: here and the line below.
https://codereview.chromium.org/264973020/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
