On 2014/05/08 10:55:03, Jakob wrote:
Nice! Some DBC, feel free to postpone to future CLs.
As far as I know, SSE2 effectively implies CMOV, so I think we can rip
out all
the "is CMOV supported?" conditionals as well.
(CMOV was introduced in the Pentium Pro in 1995, well before the P4 with
SSE2
in
2001. MSVS has always treated the /arch:SSE2 switch to imply CMOV
support, see
http://msdn.microsoft.com/en-us/library/7t5yh4fd.aspx)
https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32.h#newcode189
src/ia32/assembler-ia32.h:189: struct XMMRegister : DoubleRegister {
I think you can combine these two classes as well.
I wasn't sure about CMOV, but it seems the right thing to do. Will rip it
out
after this CL.
https://codereview.chromium.org/275433004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
