LGTM with comments.
https://codereview.chromium.org/271843005/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/271843005/diff/40001/include/v8.h#newcode3868
include/v8.h:3868: int max_semispace_size() const { return
max_semispace_size_; }
nit: What do you think about "semi_space" instead of "semispace"? I
don't mind either way, it's up to you.
https://codereview.chromium.org/271843005/diff/40001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/271843005/diff/40001/src/heap.cc#newcode5001
src/heap.cc:5001: max_semispace_size = FLAG_max_semispace_size * MB;
IMHO, this should target "max_semispace_size_" field (with trailing
underscore). Likewise for the other two below.
https://codereview.chromium.org/271843005/diff/40001/test/mjsunit/regress/regress-99167.js
File test/mjsunit/regress/regress-99167.js (right):
https://codereview.chromium.org/271843005/diff/40001/test/mjsunit/regress/regress-99167.js#newcode28
test/mjsunit/regress/regress-99167.js:28: // Flags: --expose-gc
--max_semispace_size=1
nit: Only one white-space between flags.
https://codereview.chromium.org/271843005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
