Lgtm. But I think it's safer to use ReplaceCode instead of set_code.
Done
https://codereview.chromium.org/271873003/diff/60001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/271873003/diff/60001/src/debug.cc#newcode2067
src/debug.cc:2067: EnsureFunctionHasDebugBreakSlots(fun);
On 2014/05/08 17:03:49, Yang wrote:
On 2014/05/08 17:00:45, rmcilroy wrote:
> Should there also be checks here to just continue if
function->shared() is
> toplevel or !allow_lazy_compilation like lines 2223-2224 below, or
is this not
> possible for generators (I assume they can't be builtins)?
Not sure about lazy compilation. I'll do some research tomorrow.
OK, I'll land as-is now, and leave investigation of whether generators
and lazy_compilation interact to you.
https://codereview.chromium.org/271873003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
