On 2014/05/09 13:02:50, Yang wrote:
On 2014/05/08 15:27:04, aandrey wrote:
> lgtm
>
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-promises.js
> File test/mjsunit/es6/mirror-promises.js (right):
>
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-promises.js#newcode72
> test/mjsunit/es6/mirror-promises.js:72: var m1 = debug.MakeMirror(new
Promise(
> Promise.resolve(1)
>
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-promises.js#newcode76
> test/mjsunit/es6/mirror-promises.js:76: assertEquals("[[Status]]",
> ip[0].name());
> update these also
>
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-promises.js#newcode81
> test/mjsunit/es6/mirror-promises.js:81: var m2 = debug.MakeMirror(new
> Promise(function(resolve, reject) { reject(2) }));
> Promise.reject(2)
I still don't know where this is used or why this is necessary. It's a
different
code path for doing the same thing, right?
We call getProperties and getInternalProperties on an object to dump it in
console.
Now, for a Promise instance we return empty properties. We would like to
show
status and value.
Try to run in console: console.dir(Promise.resolve(1));
https://codereview.chromium.org/273653007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
