Reviewers: Yang, Sven Panne,
Message:
It's not clear to me if this is the right way to fix this, or if d8 --prof
should set --nologfile-per-isolate implicitly. Otherwise any user trying to
use
--prof will have to look at a per-isolate file instead of plain old v8.log.
Description:
Pass --nologfile-per-isolate to d8 in plot-timer-events calibration code
This was broken by the removal of the default isolate.
Please review this at https://codereview.chromium.org/273213002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -4 lines):
M tools/plot-timer-events
Index: tools/plot-timer-events
diff --git a/tools/plot-timer-events b/tools/plot-timer-events
index
8db067d5f12c800df35dc5c4e6cffbf3743150d0..c14a909bf464e031255eda5c959bea32f735f1d6
100755
--- a/tools/plot-timer-events
+++ b/tools/plot-timer-events
@@ -37,16 +37,18 @@ if [[ "$@" != *--distortion* ]]; then
calibration_log=calibration.log
calibration_script="for (var i = 0; i < 1000000; i++) print();"
- $d8_exec --nocrankshaft --prof --logfile $calibration_log \
- --log-timer-events -e "$calibration_script" > /dev/null
+ $d8_exec --nocrankshaft --prof --log-timer-events \
+ --logfile $calibration_log --nologfile-per-isolate \
+ -e "$calibration_script" > /dev/null
t_1_start=`grep "timer-event-start,\"V8.Execute\"" $calibration_log \
| tail -n1 | awk -F, '{print $3}'`
t_1_end=`grep "timer-event-end,\"V8.Execute\"" $calibration_log \
| tail -n1 | awk -F, '{print $3}'`
n_1=`grep "timer-event\|tick" $calibration_log | wc -l`
- $d8_exec --nocrankshaft --prof --logfile $calibration_log \
- --log-internal-timer-events -e "$calibration_script" > /dev/null
+ $d8_exec --nocrankshaft --prof --log-internal-timer-events \
+ --logfile $calibration_log --nologfile-per-isolate \
+ -e "$calibration_script" > /dev/null
t_2_start=`grep "timer-event-start,\"V8.Execute\"" $calibration_log \
| tail -n1 | awk -F, '{print $3}'`
t_2_end=`grep "timer-event-end,\"V8.Execute\"" $calibration_log \
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
