LGTM with comment.
https://codereview.chromium.org/279863002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/279863002/diff/1/src/runtime.cc#newcode1787
src/runtime.cc:1787: RUNTIME_ASSERT(key->IsJSReceiver() ||
key->IsSymbol());
This applies to all four flavors of operations on weak collections (i.e.
to Get, Has, Delete and Set). Can we keep it in sync with all four
runtime functions?
https://codereview.chromium.org/279863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
