Reviewers: Dmitry Lomov (chromium),
Message:
As discussed, I mostly resolved clashes by appending "JS" to the JavaScript
names involved in them. For three Math functions I made an exception and
appended "RT" to the runtime names instead, because those JavaScript
identifiers
are used all over the compiler pipeline, so renaming those would have been
much
more intrusive (and ugly: "case kMathExpJS" and such in
{H,L}UnaryMathInstruction). We can change the approach if you're not happy
with
how this CL looks right now.
Description:
Avoid name clashes of builtins and runtime functions.
This makes it possible to use %Percent() notation to call any given builtin
or
runtime function in tests.
Please review this at https://codereview.chromium.org/280243002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+107, -122 lines):
M src/array.js
M src/arraybuffer.js
M src/bootstrapper.cc
M src/builtins.cc
M src/collection.js
M src/harmony-math.js
M src/hydrogen.cc
M src/math.js
M src/messages.js
M src/object-observe.js
M src/regexp.js
M src/runtime.h
M src/runtime.cc
M src/string.js
M src/uri.js
M src/v8natives.js
D test/mjsunit/runtime-gen/mathexp.js
A + test/mjsunit/runtime-gen/mathexprt.js
D test/mjsunit/runtime-gen/mathfloor.js
A + test/mjsunit/runtime-gen/mathfloorrt.js
D test/mjsunit/runtime-gen/mathsqrt.js
A + test/mjsunit/runtime-gen/mathsqrtrt.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
