On 2014/05/12 13:00:47, Yang wrote:
On 2014/05/12 12:55:45, Sven Panne wrote:
>
https://codereview.chromium.org/275253004/diff/1/src/ia32/assembler-ia32.h
> File src/ia32/assembler-ia32.h (left):
>
>
https://codereview.chromium.org/275253004/diff/1/src/ia32/assembler-ia32.h#oldcode726
> src/ia32/assembler-ia32.h:726: void cmov(Condition cc, Register dst,
Register
> src) {
> On 2014/05/12 12:40:32, titzer wrote:
> > Please don't remove these from the MacroAssembler!
>
> Whatever uses that should consider *not* using it. ;-) This introduces
data
> dependencies, and normally modern processors are better off using
caveman-style
> conditional branches + normal loads.
Of course I could change them into true macros: cmov would internally use
jump
and mov.
So... what do we want now? Use cmov where possible, or never use cmov? In
either
case, we would require cmov-support anyways. By now I have a CL for either
option under review...
https://codereview.chromium.org/275253004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
