Looks good, but I have a refactoring suggestion.
https://codereview.chromium.org/273383003/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/273383003/diff/1/src/api.cc#newcode1912
src/api.cc:1912: asan_fake_stack_handle_ = 0;
nit: I'd prefer s/0/NULL/ for pointers.
https://codereview.chromium.org/273383003/diff/1/src/base/macros.h
File src/base/macros.h (right):
https://codereview.chromium.org/273383003/diff/1/src/base/macros.h#newcode64
src/base/macros.h:64: #define ASAN_BUILD 1
We already define V8_USE_ADDRESS_SANITIZER in zone.h based on the same
logic. You could move that here, and reuse it for TryCatch.
When the name begins with V8_, you can skip the "must not be defined
already" check above.
https://codereview.chromium.org/273383003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
