On 2014/05/12 14:23:33, Jakob wrote:
LGTM. I think we can clean up even further, but feel free to punt on that.
https://codereview.chromium.org/284503002/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
https://codereview.chromium.org/284503002/diff/1/src/ia32/assembler-ia32.h#newcode148
src/ia32/assembler-ia32.h:148: static int NumAllocatableRegisters() {
return
kMaxNumAllocatableRegisters; }
Do we even need these methods? I think they're an artifact of the class
split
you're cleaning up.
Uploaded a new patch set. NumAllocatableRegisters() has to stay, as it is
used
in lithium. It is implemented in different ways on different ports. I
removed
NumRegisters() though.
https://codereview.chromium.org/284503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
