https://codereview.chromium.org/284773004/diff/10001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/284773004/diff/10001/test/cctest/test-heap.cc#newcode3907
test/cctest/test-heap.cc:3907: i::FLAG_compilation_cache = false;
On 2014/05/14 06:47:45, Hannes Payer wrote:
why i::FLAG_compilation_cache = false; ?
To avoid caching the generated code below. So that nothing keeps code
objects alive and it dies as soon as we leave the local scope.
https://codereview.chromium.org/284773004/diff/10001/test/cctest/test-heap.cc#newcode3932
test/cctest/test-heap.cc:3932: StartIncrementalMarking();
On 2014/05/14 06:47:45, Hannes Payer wrote:
Why do we start incremental marking again here? We started it above.
This functions starts incremental marking if it is not active.
The JS call above can trigger GC, we might need to restart marking here,
otherwise CompleteIncrementalMarking will fail.
https://codereview.chromium.org/284773004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
